chore(react-tabster): migrate to new package structure #25833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o linter doesn't fail
59 tasks
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f3e6e65b7f6435dc6b09bfd626e99921a10983d8 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Button | mount | 1277 | 929 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1321 | 1304 | 5000 | |
| Button | mount | 1277 | 929 | 5000 | Possible regression |
| FluentProvider | mount | 1598 | 1672 | 5000 | |
| FluentProviderWithTheme | mount | 630 | 639 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 583 | 597 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 923 | 648 | 10 | |
| MakeStyles | mount | 1916 | 1908 | 50000 | |
| Persona | mount | 3071 | 3024 | 5000 | |
| SpinButton | mount | 2580 | 2611 | 5000 |
Collaborator
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 1039 screenshots✅ There was 1039 screenshots added, 0 screenshots removed, 0 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference. OverflowSet.Root - RTL.default.chromium 1 screenshots
OverflowSet.Root.default.chromium 1 screenshots
SearchBox.Full - RTL.default.chromium 1 screenshots
SearchBox.Full.default.chromium 1 screenshots
SearchBox.Root - RTL.default.chromium 1 screenshots
SearchBox.Root.default.chromium 1 screenshots
SearchBox.ShowIcon - RTL.default.chromium 1 screenshots
SearchBox.ShowIcon.default.chromium 1 screenshots
unknown 1031 screenshots
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ChatDuplicateMessagesPerf.default | 243 | 210 | 1.16:1 |
| AnimationMinimalPerf.default | 437 | 382 | 1.14:1 |
| TreeWith60ListItems.default | 135 | 124 | 1.09:1 |
| FlexMinimalPerf.default | 241 | 224 | 1.08:1 |
| FormMinimalPerf.default | 327 | 302 | 1.08:1 |
| ListCommonPerf.default | 510 | 473 | 1.08:1 |
| ButtonMinimalPerf.default | 137 | 128 | 1.07:1 |
| IconMinimalPerf.default | 527 | 494 | 1.07:1 |
| EmbedMinimalPerf.default | 3002 | 2828 | 1.06:1 |
| DividerMinimalPerf.default | 292 | 279 | 1.05:1 |
| DropdownMinimalPerf.default | 2241 | 2137 | 1.05:1 |
| LayoutMinimalPerf.default | 300 | 286 | 1.05:1 |
| RosterPerf.default | 1757 | 1667 | 1.05:1 |
| ButtonSlotsPerf.default | 471 | 455 | 1.04:1 |
| CarouselMinimalPerf.default | 388 | 374 | 1.04:1 |
| ItemLayoutMinimalPerf.default | 961 | 923 | 1.04:1 |
| ListMinimalPerf.default | 421 | 406 | 1.04:1 |
| TableManyItemsPerf.default | 1560 | 1498 | 1.04:1 |
| ReactionMinimalPerf.default | 308 | 298 | 1.03:1 |
| SegmentMinimalPerf.default | 282 | 273 | 1.03:1 |
| AttachmentMinimalPerf.default | 124 | 122 | 1.02:1 |
| AvatarMinimalPerf.default | 158 | 155 | 1.02:1 |
| ListNestedPerf.default | 463 | 456 | 1.02:1 |
| ListWith60ListItems.default | 509 | 499 | 1.02:1 |
| PopupMinimalPerf.default | 524 | 516 | 1.02:1 |
| TooltipMinimalPerf.default | 1949 | 1912 | 1.02:1 |
| GridMinimalPerf.default | 278 | 275 | 1.01:1 |
| HeaderMinimalPerf.default | 296 | 292 | 1.01:1 |
| RadioGroupMinimalPerf.default | 361 | 357 | 1.01:1 |
| SkeletonMinimalPerf.default | 281 | 279 | 1.01:1 |
| TableMinimalPerf.default | 334 | 331 | 1.01:1 |
| TextMinimalPerf.default | 277 | 274 | 1.01:1 |
| TreeMinimalPerf.default | 665 | 661 | 1.01:1 |
| AccordionMinimalPerf.default | 116 | 116 | 1:1 |
| BoxMinimalPerf.default | 274 | 274 | 1:1 |
| ButtonOverridesMissPerf.default | 1080 | 1078 | 1:1 |
| CheckboxMinimalPerf.default | 1734 | 1730 | 1:1 |
| DatepickerMinimalPerf.default | 4676 | 4682 | 1:1 |
| HeaderSlotsPerf.default | 616 | 619 | 1:1 |
| LoaderMinimalPerf.default | 268 | 268 | 1:1 |
| ProviderMergeThemesPerf.default | 1061 | 1059 | 1:1 |
| SliderMinimalPerf.default | 1321 | 1315 | 1:1 |
| SplitButtonMinimalPerf.default | 3605 | 3609 | 1:1 |
| ChatWithPopoverPerf.default | 301 | 303 | 0.99:1 |
| InputMinimalPerf.default | 928 | 934 | 0.99:1 |
| PortalMinimalPerf.default | 124 | 125 | 0.99:1 |
| ProviderMinimalPerf.default | 334 | 336 | 0.99:1 |
| RefMinimalPerf.default | 178 | 179 | 0.99:1 |
| AlertMinimalPerf.default | 214 | 218 | 0.98:1 |
| ChatMinimalPerf.default | 594 | 604 | 0.98:1 |
| MenuButtonMinimalPerf.default | 1362 | 1389 | 0.98:1 |
| CustomToolbarPrototype.default | 2211 | 2250 | 0.98:1 |
| AttachmentSlotsPerf.default | 903 | 933 | 0.97:1 |
| LabelMinimalPerf.default | 299 | 309 | 0.97:1 |
| DialogMinimalPerf.default | 595 | 618 | 0.96:1 |
| MenuMinimalPerf.default | 669 | 698 | 0.96:1 |
| StatusMinimalPerf.default | 527 | 549 | 0.96:1 |
| VideoMinimalPerf.default | 584 | 606 | 0.96:1 |
| CardMinimalPerf.default | 413 | 433 | 0.95:1 |
| DropdownManyItemsPerf.default | 523 | 551 | 0.95:1 |
| ToolbarMinimalPerf.default | 699 | 749 | 0.93:1 |
| TextAreaMinimalPerf.default | 352 | 389 | 0.9:1 |
| ImageMinimalPerf.default | 271 | 305 | 0.89:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1441 | 1417 | 5000 | |
| Breadcrumb | mount | 3547 | 3708 | 1000 | |
| Checkbox | mount | 3249 | 3250 | 5000 | |
| CheckboxBase | mount | 2896 | 3005 | 5000 | |
| ChoiceGroup | mount | 5447 | 5370 | 5000 | |
| ComboBox | mount | 1545 | 1657 | 1000 | |
| CommandBar | mount | 11745 | 11440 | 1000 | |
| ContextualMenu | mount | 13781 | 13951 | 1000 | |
| DefaultButton | mount | 1715 | 1746 | 5000 | |
| DetailsRow | mount | 4563 | 4642 | 5000 | |
| DetailsRowFast | mount | 4367 | 4689 | 5000 | |
| DetailsRowNoStyles | mount | 4338 | 4290 | 5000 | |
| Dialog | mount | 3827 | 3830 | 1000 | |
| DocumentCardTitle | mount | 725 | 735 | 1000 | |
| Dropdown | mount | 3887 | 3962 | 5000 | |
| FocusTrapZone | mount | 2438 | 2419 | 5000 | |
| FocusZone | mount | 2453 | 2528 | 5000 | |
| GroupedList | mount | 2286 | 2737 | 2 | |
| GroupedList | virtual-rerender | 1413 | 1405 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 2071 | 2061 | 2 | |
| GroupedListV2 | mount | 702 | 689 | 2 | |
| GroupedListV2 | virtual-rerender | 673 | 683 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 695 | 710 | 2 | |
| IconButton | mount | 2362 | 2367 | 5000 | |
| Label | mount | 901 | 899 | 5000 | |
| Layer | mount | 5357 | 5289 | 5000 | |
| Link | mount | 1043 | 1019 | 5000 | |
| MenuButton | mount | 2089 | 2089 | 5000 | |
| MessageBar | mount | 2839 | 2969 | 5000 | |
| Nav | mount | 3915 | 4028 | 1000 | |
| OverflowSet | mount | 1694 | 1685 | 5000 | |
| Panel | mount | 3135 | 3198 | 1000 | |
| Persona | mount | 1542 | 1564 | 1000 | |
| Pivot | mount | 1989 | 2076 | 1000 | |
| PrimaryButton | mount | 1867 | 1849 | 5000 | |
| Rating | mount | 8665 | 8763 | 5000 | |
| SearchBox | mount | 1904 | 1783 | 5000 | |
| Shimmer | mount | 3474 | 3583 | 5000 | |
| Slider | mount | 2552 | 2580 | 5000 | |
| SpinButton | mount | 5781 | 5645 | 5000 | |
| Spinner | mount | 980 | 992 | 5000 | |
| SplitButton | mount | 3831 | 3765 | 5000 | |
| Stack | mount | 1003 | 1045 | 5000 | |
| StackWithIntrinsicChildren | mount | 3177 | 3033 | 5000 | |
| StackWithTextChildren | mount | 5896 | 6133 | 5000 | |
| SwatchColorPicker | mount | 12498 | 12651 | 5000 | |
| TagPicker | mount | 3336 | 3211 | 5000 | |
| TeachingBubble | mount | 103820 | 106719 | 5000 | |
| Text | mount | 972 | 973 | 5000 | |
| TextField | mount | 1934 | 2029 | 5000 | |
| ThemeProvider | mount | 1926 | 1898 | 5000 | |
| ThemeProvider | virtual-rerender | 1340 | 1316 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2683 | 2699 | 5000 | |
| Toggle | mount | 1363 | 1378 | 5000 | |
| buttonNative | mount | 691 | 699 | 5000 |
TristanWatanabe
commented
Nov 29, 2022
scripts/tasks/eslint.ts
Outdated
| return storyPath; | ||
| }) | ||
| .flat() | ||
| .some(fileName => constants.extensions.includes(path.extname(fileName))); |
Member
Author
There was a problem hiding this comment.
Added this extra check which makes sure a valid file exists within the stories/ subfolder because linter errors out when running for this package after the migration since the stories/ subfolder won't contain any of the valid extensions (.ts,.tsx,.js,.jsx) and only contains one story with a .mdx extension. just-scripts eslintTask doesn't seem to support the no-error-on-unmatched-pattern eslint CLI argument so this is a workaround.
Member
Author
There was a problem hiding this comment.
This approach causes quite the pipeline job slowdown 😰 so will need to rethink
Member
Author
There was a problem hiding this comment.
Decided to move the problematic FocusIndicator.stories.mdx from @fluentui/react-tabster to @fluentui/react-components package as part of the Accessibility section and remove the storybook setup from @fluentui/react-tabster instead.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5b62cd0:
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
ling1726
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
migrate-converged-pkgwhich reflects updates made in chore(migrate-converged): add functionality to execute various v9 package file restructuring tasks #24458.common/folder and moves contents to newtesting/folderdocs/folder to package root.FocusIndicator.stories.mdxfrom@fluentui/react-tabsterto@fluentui/react-componentspackage as part of theAccessibilityconcepts and remove the storybook setup from@fluentui/react-tabster.Issue: